Add rotation and position parameters to hand-controls. #5766
+13
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adjustment for Pico4 has been removed. It set the handModelOrientationX to -45 degrees, which now is the default value. As a result this adjustment is not neede anymore.
filandra
force-pushed
the
add-rotation-position-hand-controls
branch
from
f0df2a7 to
b64fbe2
Compare
Author
Member
|
Thanks. If any rotation is needed the rotation should be handled internally or |
1stmu33
approved these changes
Jan 9, 2026
Author
|
@dmarcos sorry for the delay - the holidays were very busy hahah. What do you mean by internally? Should it be handled in some other module? I figured that I would place the rotation handling into the same place where it was being already modified previously. |
Contributor
|
@filandra This means removing offSetRotation offSetPosition properties you added, put back the offset directly in radians inline in the code, so Math.PI / 4 for everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added the ability to set the rotation and position of hand-controls.
Default rotation and position is aligned with Meta Quest Controllers.
The adjustment for Pico4 has been removed.
It set the handModelOrientationX to -45 degrees, which now is the default value. As a result this adjustment is not needed anymore.